fix(safe): close transaction-shape and guard validation gaps [ENG-4235] - #103
Merged
makemake-kbo merged 6 commits intoAug 5, 2026
Conversation
makemake-kbo
requested review from
fredo,
lean-apple and
mateo-mro
as code owners
August 3, 2026 11:23
mateo-mro
reviewed
Aug 3, 2026
mateo-mro
requested changes
Aug 4, 2026
mateo-mro
reviewed
Aug 5, 2026
mateo-mro
previously approved these changes
Aug 5, 2026
mateo-mro
approved these changes
Aug 5, 2026
makemake-kbo
deleted the
makemake/eng-4235-fixsafe-close-transaction-shape-and-guard-validation-gaps
branch
August 5, 2026 14:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
FOUNDRY_PROFILE=safe pcl test(2 passed)FOUNDRY_PROFILE=safe-guard forge test --offline --match-path test/protection/safe/integration/CredibleSafeGuardScripts.t.sol(18 passed)forge fmt --checkLinear: ENG-4235