Skip to content

fix(safe): close transaction-shape and guard validation gaps [ENG-4235] - #103

Merged
makemake-kbo merged 6 commits into
masterfrom
makemake/eng-4235-fixsafe-close-transaction-shape-and-guard-validation-gaps
Aug 5, 2026
Merged

fix(safe): close transaction-shape and guard validation gaps [ENG-4235]#103
makemake-kbo merged 6 commits into
masterfrom
makemake/eng-4235-fixsafe-close-transaction-shape-and-guard-validation-gaps

Conversation

@makemake-kbo

Copy link
Copy Markdown
Contributor

Summary

  • make the shared Safe protection contracts the single maintained source while preserving example imports
  • enforce CALL MultiSend outer-value and actual allowance-owner semantics, and reject transient cumulative allowance grants above policy caps
  • align deployment registry validation with runtime 50k-gas, exact-return, canonical-bool, and future-block rules
  • document tested module-set limits and add regressions for CALL batches, transient approvals, malformed/slow registries, and future credible blocks

Validation

  • FOUNDRY_PROFILE=safe pcl test (2 passed)
  • targeted Safe PCL regressions for transient grants, CALL owner semantics, and outer value (3 passed)
  • FOUNDRY_PROFILE=safe-guard forge test --offline --match-path test/protection/safe/integration/CredibleSafeGuardScripts.t.sol (18 passed)
  • forge fmt --check

Linear: ENG-4235

@linear-code

linear-code Bot commented Aug 3, 2026

Copy link
Copy Markdown

ENG-4235

Comment thread src/protection/safe/SafeTxShapeHelpers.sol Outdated
Comment thread src/protection/safe/SafeTxShapeHelpers.sol Outdated

@lean-apple lean-apple left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread src/protection/safe/SafeTxShapeHelpers.sol
Comment thread src/protection/safe/README.md
mateo-mro
mateo-mro previously approved these changes Aug 5, 2026
@makemake-kbo
makemake-kbo merged commit 0773cd5 into master Aug 5, 2026
11 checks passed
@makemake-kbo
makemake-kbo deleted the makemake/eng-4235-fixsafe-close-transaction-shape-and-guard-validation-gaps branch August 5, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants