fix(vault): verify ERC-4626 operation state effects - #102
Open
makemake-kbo wants to merge 6 commits into
Open
Conversation
makemake-kbo
requested review from
fredo,
lean-apple and
mateo-mro
as code owners
August 3, 2026 11:15
mateo-mro
reviewed
Aug 3, 2026
mateo-mro
reviewed
Aug 4, 2026
lean-apple
reviewed
Aug 4, 2026
mateo-mro
reviewed
Aug 5, 2026
| PhEvm.CallFilter memory filter = PhEvm.CallFilter({ | ||
| callType: 0, minDepth: 0, maxDepth: type(uint32).max, topLevelOnly: false, successOnly: true | ||
| }); | ||
| PhEvm.TriggerCall[] memory calls = ph.matchingCalls(vault, ctx.selector, filter, 8); |
There was a problem hiding this comment.
Capping this lookup at eight makes the ninth valid deposit or mint in one transaction revert because its call id can never be found. That turns the performance bound into an undocumented protocol restriction. Could we either resolve the caller without a global prefix scan or explicitly enforce and document a supported call count at registration?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pcl test --match-contract ERC4626PreviewAssertionTest(7 passing)Linear: ENG-4234