fix(guards): prevent activation of unresolved semantic gaps - #100
fix(guards): prevent activation of unresolved semantic gaps#100makemake-kbo wants to merge 3 commits into
Conversation
| /// @notice Wires the v1 call-scoped accounting checks. | ||
| function triggers() external view override { | ||
| _registerVaultFlowTriggers(); | ||
| // Quarantined until v1 identity is pinned and self-recipient/fee-on-transfer claims plus |
There was a problem hiding this comment.
[P2] Describe this wrapper as inert
The contract NatSpec still says the call-scoped v1 accounting checks are armed, but triggers() now registers nothing. Similar stale “Registers”, “Wires”, and “Protects” wording remains on the other quarantined contracts. Source and generated documentation could therefore lead an integrator to deploy an inert security wrapper. Please update the contract-level and triggers() NatSpec across all quarantined wrappers to explicitly state that they are unavailable and register no triggers.
| registerFnCallTrigger( | ||
| this.assertLiquidationReducesBorrowerDebt.selector, IAaveV4Spoke.liquidationCall.selector | ||
| ); | ||
| // Quarantined: reserve enumeration has no protocol-level maximum and therefore cannot be |
There was a problem hiding this comment.
[P2] Cover every quarantined wrapper
The new no-registration tests cover Hub, Balancer, Lighter, and SymbioticVaultProtection, but not this Spoke wrapper, Spark, the Euler bundle/share-price wrapper, or the top-level Symbiotic wrapper. Preventing trigger registration is the safety behavior introduced by this PR, so please add the same trigger-recorder regression for every published wrapper being quarantined.
3 participants
Summary
Validation
aave,balancer,spark,euler,lighter, andsymbioticprofiles offlineLinear: ENG-4232