Conversation
The pattern for columns names is that parameter X will have an associated column XError for the uncertainty in a measurement. This was not followed for the HalfLifeSeconds calculated column but this commit corrects that.
We were storing an empty string as a value rather than converting to null or missing. Add an empty string as a na value during parsing.
I thought we were already doing this, but turns out only for bool, ints and strings, and not for floats.
We did a lot of casting to different types at various points in the function. We now cast as string at the start so we can do all the things we need to do.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
==========================================
- Coverage 99.55% 99.55% -0.01%
==========================================
Files 15 15
Lines 451 448 -3
==========================================
- Hits 449 446 -3
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had
HalfLifeErrorSecondswhere all other parameters haveErrorat the end. Update to be consistent.While working on this I also decided we should use
pd.NAfor missing or non-existent data. We can achieve this by ensuring to used pandas nullable types, so in this PR it's mainly changingfloat64toFloat64. This relates to #30.I also tidied up the parse_half_life function used when reading the NUBASE data. No change to functionality, just some changes around how often we were switching between different types to apply various modifications.