Repository navigation
Conversation
Map PHPUnit string parameter names and retain caller weak/strict coercion, message validation, evaluation order and void results through typed closures. Keep safe standalone calls concise and unsupported bindings available for manual migration. Execute converted weak and strict fixtures through the CLI in child processes and check each test's outcome and assertion count. Refs php-testo#390 Assisted-By: GPT-6 <noreply@anthropic.com>
Keep weak and strict runtime inputs beside their feature tests instead of storing a second copy of the generated PHP. Retain all per-test outcomes, assertion counts and strict TypeError checks. Cover concise named calls in the existing contains fixture so the generated short form still has a golden check. Refs php-testo#390 Assisted-By: GPT-6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPUnit string assertion migration can produce invalid named calls, reject values accepted through weak coercion, reorder argument side effects and change a used assertion's result.
Map PHPUnit's source parameter names explicitly. Safe standalone calls with native string arguments keep the short fluent form. Other supported string calls use a typed void closure to preserve named binding, caller weak/strict coercion, message validation, evaluation order and null results. Unsupported named/unpacked call shapes stay available for manual migration.
Keep runtime input fixtures beside the feature tests and verify concise named output in a co-located golden fixture. Execute the full migration set and the converted code in a child process. Check every converted test's outcome, assertion count and strict TypeError class; include a required failing assertion so a dropped assertion cannot pass the regression suite.
Validation:
Part of #390. PHPUnit method ownership is handled in #395. Both PRs target 1.x independently; review #395 first.