ia32/console-vga: fix implicit fallthrough#433
Merged
Conversation
TASK: RTOS-1371
There was a problem hiding this comment.
Code Review
This pull request modifies hal/ia32/console-vga.c by adding an explicit /* fallthrough */ comment in the console printing switch-case statement and resetting the escape state halconsole_common.esc to esc_init after processing escape parameters. There are no review comments, so I have no feedback to provide.
anglov
approved these changes
Jul 10, 2026
anglov
left a comment
Member
There was a problem hiding this comment.
Sorry for not catching it while doing the changes – forgot that vga mode in ia32 is not tested on CI :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TASK: RTOS-1371
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment