Skip to content

ia32/console-vga: fix implicit fallthrough#433

Merged
lukileczo merged 1 commit into
masterfrom
lukileczo/fallthrough-fix
Jul 10, 2026
Merged

ia32/console-vga: fix implicit fallthrough#433
lukileczo merged 1 commit into
masterfrom
lukileczo/fallthrough-fix

Conversation

@lukileczo

Copy link
Copy Markdown
Member

TASK: RTOS-1371

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@lukileczo
lukileczo requested review from a team and anglov July 10, 2026 13:27

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies hal/ia32/console-vga.c by adding an explicit /* fallthrough */ comment in the console printing switch-case statement and resetting the escape state halconsole_common.esc to esc_init after processing escape parameters. There are no review comments, so I have no feedback to provide.

@anglov anglov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not catching it while doing the changes – forgot that vga mode in ia32 is not tested on CI :(

@github-actions

Copy link
Copy Markdown

Unit Test Results

10 890 tests  ±0   10 220 ✅ ±0   54m 7s ⏱️ - 1m 42s
   680 suites ±0      670 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit d9502e8. ± Comparison against base commit ff5e7e9.

@lukileczo
lukileczo merged commit 23171e3 into master Jul 10, 2026
47 checks passed
@lukileczo
lukileczo deleted the lukileczo/fallthrough-fix branch July 10, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants