Skip to content

Preparation to enable -Wimplicit-fallthrough in build flags#431

Merged
anglov merged 3 commits into
masterfrom
anglov/fallthrough
Jul 3, 2026
Merged

Preparation to enable -Wimplicit-fallthrough in build flags#431
anglov merged 3 commits into
masterfrom
anglov/fallthrough

Conversation

@anglov

@anglov anglov commented Jul 2, 2026

Copy link
Copy Markdown
Member

Description

Motivation and Context

Preparation to enable -Wimplicit-fallthrough in build flags

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds explicit /* fallthrough */ comments to switch-case statements in hal/riscv64/dtb.c and lib/format.c to clarify intentional fall-through behavior, and adds a state reset in devices/tty-bios/tty-bios.c. The reviewer suggests using a fall-through comment in devices/tty-bios/tty-bios.c as well to avoid duplicating the reset logic before the default case.

Comment thread devices/tty-bios/tty-bios.c
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Unit Test Results

10 890 tests  +305   10 220 ✅ +306   53m 15s ⏱️ -2s
   680 suites + 31      670 💤 ±  0 
     1 files   ±  0        0 ❌  -   1 

Results for commit 2618978. ± Comparison against base commit a139fa2.

This pull request removes 3 and adds 308 tests. Note that renamed tests count towards both.
phoenix-rtos-tests/libcache/unit ‑ armv7m4-stm32l4x6-nucleo:phoenix-rtos-tests/libcache/unit
phoenix-rtos-tests/libcache/unit ‑ armv7m7-imxrt106x-evk:phoenix-rtos-tests/libcache/unit
phoenix-rtos-tests/libcache/unit ‑ armv7m7-imxrt117x-evk:phoenix-rtos-tests/libcache/unit
phoenix-rtos-tests/libc/posixsrv ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/libc/posixsrv.tmpfile.basic
phoenix-rtos-tests/libc/posixsrv ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/libc/posixsrv.tmpfile.binary
phoenix-rtos-tests/libc/posixsrv ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/libc/posixsrv.tmpfile.multiple
phoenix-rtos-tests/libc/posixsrv ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/posixsrv.tmpfile.basic
phoenix-rtos-tests/libc/posixsrv ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/posixsrv.tmpfile.binary
phoenix-rtos-tests/libc/posixsrv ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/posixsrv.tmpfile.multiple
phoenix-rtos-tests/libc/posixsrv ‑ armv7a9-zynq7000-qemu:phoenix-rtos-tests/libc/posixsrv.tmpfile.basic
phoenix-rtos-tests/libc/posixsrv ‑ armv7a9-zynq7000-qemu:phoenix-rtos-tests/libc/posixsrv.tmpfile.binary
phoenix-rtos-tests/libc/posixsrv ‑ armv7a9-zynq7000-qemu:phoenix-rtos-tests/libc/posixsrv.tmpfile.multiple
phoenix-rtos-tests/libc/posixsrv ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/libc/posixsrv.tmpfile.basic
…

♻️ This comment has been updated with latest results.

@anglov

anglov commented Jul 2, 2026

Copy link
Copy Markdown
Member Author

@lukileczo could you look into riscv dtb parsing? I think that fallthrough is valid but would be great to confirm

@anglov
anglov requested a review from a team July 2, 2026 14:14
@lukileczo

Copy link
Copy Markdown
Member

@lukileczo could you look into riscv dtb parsing? I think that fallthrough is valid but would be great to confirm

Yes, the fallthrough is intentional there

@anglov
anglov force-pushed the anglov/fallthrough branch from fd4809b to 2618978 Compare July 2, 2026 16:04
@anglov anglov changed the title Preparation to enable -Wimplicit-fallthtough in build flags Preparation to enable -Wimplicit-fallthrough in build flags Jul 2, 2026
@anglov
anglov merged commit ff5e7e9 into master Jul 3, 2026
47 checks passed
@anglov
anglov deleted the anglov/fallthrough branch July 3, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants