Preparation to enable -Wimplicit-fallthrough in build flags#431
Conversation
TASK: RTOS-1371
There was a problem hiding this comment.
Code Review
This pull request adds explicit /* fallthrough */ comments to switch-case statements in hal/riscv64/dtb.c and lib/format.c to clarify intentional fall-through behavior, and adds a state reset in devices/tty-bios/tty-bios.c. The reviewer suggests using a fall-through comment in devices/tty-bios/tty-bios.c as well to avoid duplicating the reset logic before the default case.
Unit Test Results10 890 tests +305 10 220 ✅ +306 53m 15s ⏱️ -2s Results for commit 2618978. ± Comparison against base commit a139fa2. This pull request removes 3 and adds 308 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
@lukileczo could you look into riscv dtb parsing? I think that fallthrough is valid but would be great to confirm |
Yes, the fallthrough is intentional there |
TASK: RTOS-1371
TASK: RTOS-1371
fd4809b to
2618978
Compare
Description
Motivation and Context
Preparation to enable -Wimplicit-fallthrough in build flags
Types of changes
How Has This Been Tested?
Checklist:
Special treatment