imx6ull: build usbacm as a lib driver#252
Conversation
JIRA: RTOS-970
Summary of ChangesHello @adamgreloch, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enabling the USB CDC ACM driver for the i.MX6ULL platform by modifying the relevant build script. This change is essential for supporting USB serial communication, which is a common requirement for embedded systems needing virtual COM port functionality over USB. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly adds the libusbdrv-usbacm library to the build for the imx6ull target, which aligns with the goal of building usbacm as a library driver. The change is functionally correct. However, I've identified a maintainability issue in the build script where phoenix-rtos-usb is built in two separate steps. Consolidating these would improve the script's clarity and efficiency. Please see the detailed comment.
|
|
||
| b_log "Building phoenix-rtos-usb" | ||
| make -C "phoenix-rtos-usb" usb usb-install USB_HCD_LIBS="libusbehci" | ||
| make -C "phoenix-rtos-usb" usb usb-install USB_HCD_LIBS="libusbehci" USB_HOSTDRV_LIBS="libusbdrv-usbacm" |
There was a problem hiding this comment.
This is the second make invocation for phoenix-rtos-usb in this script. The first one is on line 31. The log message Building phoenix-rtos-usb is also duplicated on lines 30 and 36. This redundancy makes the script less maintainable and potentially inefficient. Consider consolidating both make calls for phoenix-rtos-usb into a single command to improve the script's readability and structure.
1 participant
JIRA: RTOS-970
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment