pthread: implement mutexattrs and mutex_{get,set}prioceiling#508
Draft
adamgreloch wants to merge 2 commits into
Draft
pthread: implement mutexattrs and mutex_{get,set}prioceiling#508adamgreloch wants to merge 2 commits into
adamgreloch wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements several POSIX mutex and mutex attribute functions, including priority ceiling, protocol, robustness, and process-shared attributes. The review feedback identifies several critical issues that need to be addressed: missing lazy initialization in pthread_mutex_getprioceiling for statically initialized mutexes, missing NULL pointer checks on mutex and attr arguments across multiple functions that could lead to crashes, duplicate declarations of pthread_mutexattr_gettype and pthread_mutexattr_settype in include/pthread.h, and a trailing semicolon after pthread_mutexattr_getpshared.
adamgreloch
force-pushed
the
adamgreloch/RTOS-1399
branch
from
July 21, 2026 17:45
39ed622 to
abb0349
Compare
TASK: RTOS-1399
adamgreloch
force-pushed
the
adamgreloch/RTOS-1399
branch
from
July 22, 2026 06:11
abb0349 to
65abd14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TASK: RTOS-1399
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment