[RTLD] Add support for PIC and being build as shared library by badochov · Pull Request #334 · phoenix-rtos/libphoenix

badochov · 2024-01-30T14:57:52Z

Description

Motivation and Context

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

Already covered by automatic testing.
New test added: (add PR link here).
Tested by hand on: (list targets here).

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing linter checks and tests passed.
My changes generate no new compilation warnings for any of the targets.

Special treatment

This PR needs additional PRs to work (list the PRs, preferably in merge-order).
I will merge this PR by myself when appropriate.

badochov · 2024-01-30T14:58:50Z

FIrst 3 commits are from different PRs

github-actions · 2024-01-31T15:36:52Z

Unit Test Results

6 780 tests - 920 6 154 ✅ - 831 31m 19s ⏱️ - 8m 9s
380 suites - 56 626 💤 - 89
1 files ± 0 0 ❌ ± 0

Results for commit 77c8fec. ± Comparison against base commit 3375557.

This pull request removes 920 tests.

flash ‑ armv7a9-zynq7000-zedboard:flash
phoenix-rtos-tests/cpp/hello-cpp ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/cpp/hello-cpp
phoenix-rtos-tests/initfini/main ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/initfini/main
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_in
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_in_big
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_inout
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_inout_big
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_out
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_out_big
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.in_val
…

♻️ This comment has been updated with latest results.

JIRA: RTOS-664

In PIE on ia32 function calls should be made using GOT. JIRA: RTOS-664

JIRA: RTOS-664

This allows constructor handling mechanism in dynamic linker. JIRA: RTOS-664

JIRA: RTOS-664

badochov requested a review from agkaminski January 30, 2024 14:57

badochov force-pushed the badochov/dynamic-linker branch from 9687533 to 37487af Compare January 30, 2024 15:13

badochov mentioned this pull request Jan 30, 2024

[RTLD] Dynamic linker phoenix-rtos/phoenix-rtos-project#990

Draft

13 tasks

badochov force-pushed the badochov/dynamic-linker branch from 37487af to 3da17c2 Compare January 31, 2024 15:24

badochov force-pushed the badochov/dynamic-linker branch 3 times, most recently from c2c4a95 to cfc9a6e Compare February 2, 2024 13:23

badochov force-pushed the badochov/dynamic-linker branch from cfc9a6e to 77c8fec Compare August 5, 2024 17:06

badochov force-pushed the badochov/dynamic-linker branch from 77c8fec to ddc8fe7 Compare August 16, 2024 12:36

github-actions Bot reviewed Aug 16, 2024

View reviewed changes

Comment thread include/sys/threads.h Outdated

Comment thread sys/threads.c Outdated

Comment thread sys/threads.c Outdated

Comment thread sys/threads.c Outdated

Comment thread sys/threads.c Outdated

Comment thread sys/threads.c Outdated

badochov force-pushed the badochov/dynamic-linker branch from ddc8fe7 to 9fe5f55 Compare August 16, 2024 12:56

github-actions Bot reviewed Aug 16, 2024

View reviewed changes

Comment thread include/dlfcn.h Outdated

Comment thread include/dlfcn.h Outdated

badochov force-pushed the badochov/dynamic-linker branch from 2caa8d8 to b72127e Compare August 21, 2024 11:22

github-actions Bot reviewed Aug 21, 2024

View reviewed changes

Comment thread rtld/stubs.c Outdated

badochov force-pushed the badochov/dynamic-linker branch 3 times, most recently from ab44ee8 to fd5b08c Compare August 27, 2024 16:02

github-actions Bot reviewed Aug 27, 2024

View reviewed changes

Comment thread misc/init.c Outdated

Comment thread misc/init.c Outdated

badochov force-pushed the badochov/dynamic-linker branch 2 times, most recently from 3243e14 to 9547eeb Compare August 29, 2024 16:13

github-actions Bot reviewed Aug 29, 2024

View reviewed changes

Comment thread arch/arm/v7a/tls.S Outdated

Comment thread arch/riscv64/tls.S Outdated

badochov force-pushed the badochov/dynamic-linker branch from 9547eeb to bee4ca6 Compare September 2, 2024 16:43

github-actions Bot reviewed Sep 2, 2024

View reviewed changes

Comment thread rtld/stubs.c Outdated

Comment thread rtld/stubs.c Outdated

badochov force-pushed the badochov/dynamic-linker branch from bee4ca6 to cae7c5e Compare September 2, 2024 17:01

github-actions Bot reviewed Sep 2, 2024

View reviewed changes

Comment thread rtld/stubs.c Outdated

Comment thread rtld/stubs.c Outdated

badochov force-pushed the badochov/dynamic-linker branch 3 times, most recently from 1fbfbc1 to 531abff Compare September 5, 2024 14:21

badochov force-pushed the badochov/dynamic-linker branch 2 times, most recently from 6f6f34b to ab58b63 Compare September 12, 2024 10:42

badochov force-pushed the badochov/dynamic-linker branch 4 times, most recently from d761924 to 0ba38c3 Compare September 18, 2024 07:35

badochov force-pushed the badochov/dynamic-linker branch 5 times, most recently from a561b47 to 47a6b37 Compare October 6, 2024 16:31

badochov force-pushed the badochov/dynamic-linker branch 2 times, most recently from 90eeca8 to 046a16f Compare October 25, 2024 14:32

badochov force-pushed the badochov/dynamic-linker branch from 046a16f to 5a9ff9b Compare December 5, 2024 12:26

badochov mentioned this pull request Mar 18, 2025

[DO NOT MERGE]PIC #317

Closed

13 tasks

badochov force-pushed the badochov/dynamic-linker branch 3 times, most recently from 1af57c0 to 7e65870 Compare March 27, 2025 12:54

badochov and others added 11 commits March 27, 2025 23:52

libphoenix: Add option to compile as PIC

9a38908

JIRA: RTOS-664

ia32: support PIE in asm

7e6a31e

In PIE on ia32 function calls should be made using GOT. JIRA: RTOS-664

Makefile: generate shared library

db5c648

JIRA: RTOS-664

dlfcn: create header and stub definitions

4c14d66

JIRA: RTOS-664

tls: add dynamic linker TLS support

1a1ee25

JIRA: RTOS-664

ld.elf_so: add support for __cxa_thread_atexit_impl

e7db14c

JIRA: RTOS-664

init: declare _libc_init as constructor

cd168a3

This allows constructor handling mechanism in dynamic linker. JIRA: RTOS-664

shared.mk: install toolchain provided dynamic libraries

71d156d

JIRA: RTOS-664

shared.mk: strip shared libs in fs

3edaf74

JIRA: RTOS-664

arch/riscv64: respect PIC in asm

427252a

JIRA: RTOS-664

sparc: make asm PIC friendly

42d20dd

JIRA: RTOS-664

badochov force-pushed the badochov/dynamic-linker branch from 7e65870 to 42d20dd Compare March 27, 2025 22:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[RTLD] Add support for PIC and being build as shared library#334

[RTLD] Add support for PIC and being build as shared library#334
badochov wants to merge 11 commits into
masterfrom
badochov/dynamic-linker

badochov commented Jan 30, 2024 •

edited by Mateusz1223

Loading

Uh oh!

badochov commented Jan 30, 2024

Uh oh!

github-actions Bot commented Jan 31, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

badochov commented Jan 30, 2024 • edited by Mateusz1223 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

Types of changes

How Has This Been Tested?

Checklist:

Special treatment

Uh oh!

badochov commented Jan 30, 2024

Uh oh!

github-actions Bot commented Jan 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

badochov commented Jan 30, 2024 •

edited by Mateusz1223

Loading

github-actions Bot commented Jan 31, 2024 •

edited

Loading