Skip to content

Update Rust crate getrandom to 0.4 #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renovate merged 1 commit into from
Aug 3, 2026
Merged

Update Rust crate getrandom to 0.4 #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 5 additions & 21 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ path = "src/main.rs"

[dependencies]
cef = { version = "=150.2.1", default-features = false }
getrandom = "0.3"
getrandom = "0.4"

@coderabbitai coderabbitai Bot Jul 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '\n== Cargo.toml ==\n'
nl -ba Cargo.toml | sed -n '1,40p'

printf '\n== src/app/ids.rs ==\n'
nl -ba src/app/ids.rs | sed -n '1,120p'

printf '\n== getrandom references ==\n'
rg -n "getrandom::|getrandom =" -S .

Repository: phob/MediaFlick-Desktop

Length of output: 219

🏁 Script executed:

#!/bin/bash
set -euo pipefail

python3 - <<'PY'
import pathlib, re, sys
path = pathlib.Path("Cargo.toml")
text = path.read_text()
m = re.search(r'^\s*getrandom\s*=\s*"([^"]+)"', text, re.M)
print("Cargo.toml getrandom version:", m.group(1) if m else "not found")
PY

Repository: phob/MediaFlick-Desktop

Length of output: 195

🏁 Script executed:

#!/bin/bash
set -euo pipefail

sed -n '1,120p' src/app/ids.rs | nl -ba

Repository: phob/MediaFlick-Desktop

Length of output: 201

🏁 Script executed:

#!/bin/bash
set -euo pipefail

python3 - <<'PY'
from pathlib import Path
for p in [Path("Cargo.toml"), Path("src/app/ids.rs")]:
    print(f"\n## {p}")
    if p.exists():
        for i, line in enumerate(p.read_text().splitlines(), 1):
            if p.name == "Cargo.toml" and i <= 30:
                print(f"{i:>4}: {line}")
            elif p.name == "ids.rs" and i <= 60:
                print(f"{i:>4}: {line}")
    else:
        print("missing")
PY

Repository: phob/MediaFlick-Desktop

Length of output: 2717

🌐 Web query:

getrandom 0.4 docs getrandom function renamed to fill removed

💡 Result:

In the getrandom crate, starting with version 0.4.0, the functions previously known as getrandom and getrandom_uninit were renamed to fill and fill_uninit, respectively [1][2][3]. This change was implemented to provide more concise and descriptive naming conventions for the library's primary functions [3]. As of version 0.4.x, you should use getrandom::fill to populate a byte buffer with random data: use getrandom::fill; let mut buf = [0u8; 32]; fill(&mut buf)?; For working with potentially uninitialized memory, the corresponding function is now fill_uninit [4][5]. These changes were part of a series of updates in the 0.4 release cycle [1][6].

Citations:

Update src/app/ids.rs for getrandom 0.4
getrandom::getrandom was removed in 0.4; switch the call at src/app/ids.rs:13 to getrandom::fill, or this dependency bump will fail to compile.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Cargo.toml` at line 13, Update the getrandom call in the ID generation logic
of src/app/ids.rs to use getrandom::fill instead of the removed
getrandom::getrandom API, preserving the existing buffer and error-handling
behavior.

serde = { version = "1", features = ["derive"] }
serde_json = "1"
tracing = "0.1"
Expand Down