Update 3-temperatures solver scheme for transient_temperature method - #173
Open
ecieren wants to merge 2 commits into
Open
Update 3-temperatures solver scheme for transient_temperature method#173ecieren wants to merge 2 commits into
ecieren wants to merge 2 commits into
Conversation
…ns of the mathematical model Signed-off-by: Emmanuel Cieren <emmanuel.cieren@mews-labs.com>
Signed-off-by: Emmanuel Cieren <emmanuel.cieren@mews-labs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
The closest would be the feature, but it can be discussed. It is a small change in beahviour for core and surface temperature in transient mode.
What is the current behavior?
When using the
Solver3T(non-legacy)transient_temperaturemethod, for steep (non-continuous) changes of transit (respectively wind speed), the core temperature (resp. surface temperature) was also non-continuous. This was okay(ish) since it was following the underlying model which was solved.What is the new behavior (if this is a feature change)?
As a new model has been introduced last year, which ensure continuity off all three temperatures, this PR propose an update to match the solve.
No test were added since numerical results are not covered. A good point would be to have non-regression tests that cover all heat_equation and model but it is out of the scope of this PR.
Does this PR introduce a breaking change or deprecate an API?
Other information: