-
Notifications
You must be signed in to change notification settings - Fork 5
Add IST reduction #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Add IST reduction #119
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
b6951ff
feat(#97): Add IST reduction feature
lou-qui afd5121
docs: Add a notebook with an example
lou-qui a5dbd8c
docs: Document IST reduction
lou-qui 8f677b5
Use secant (quasi-newton) method
lou-qui bdfd181
Fix some sonarqube errors
lou-qui a85d00f
Ignore sonarqube error about cognitive complexity
lou-qui 3d04327
Refacto ConvectiveCooling and fix handling of wind_attack_angle
lou-qui 8fd9602
Various fixes
lou-qui c9ce67e
Remove dead code and add test
lou-qui 46c4aa8
Add tests
lou-qui ef18376
Add type hints
lou-qui 1272311
Formatting + improvements after review
lou-qui 3a2c68d
Merge remote-tracking branch 'origin/main' into feature/#97/ist-reduc…
lou-qui 74a55d8
Use logger instead of print
lou-qui 0f5a911
Improvements after review
lou-qui 8c78c26
notebooks: Update Ist reduction notebook
lou-qui f1de9d6
Fix handling of solar heating/solar irradiance
lou-qui 9280678
Merge remote-tracking branch 'origin/main' into feature/#97/ist-reduc…
lou-qui bc474f6
Merge remote-tracking branch 'origin/main' into feature/#97/ist-reduc…
lou-qui File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure but I was expecting to check the size of the input before creating the mask. But it could be an intended behavior (built in numpy raise)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll check the size of the input in
_check_argumentsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed my mind, it's easier to check it here