Hotfix: loads saved by memento - #492
Merged
Merged
Conversation
Signed-off-by: WANG Jérémy <jeremy.wang@rte-france.com>
Signed-off-by: WANG Jérémy <jeremy.wang@rte-france.com>
Signed-off-by: WANG Jérémy <jeremy.wang@rte-france.com>
Signed-off-by: WANG Jérémy <jeremy.wang@rte-france.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses load-handling correctness when using the memento/rollback workflow by ensuring memoized state derived from load layout is refreshed, and by making SectionStudy.set_loads() update the intermediate state used for warm-start/rollback scenarios.
Changes:
- Invalidate cached “merge indices” in the Ducloux balance model during
reset()so load-layout-dependent merges are recomputed. - After
SectionStudy.set_loads(), trigger an intermediate warm-start solve so the stored intermediate memento reflects the updated load layout.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/mechaphlowers/core/models/balance/models/model_ducloux.py | Clears memoized merge-index/cache attributes on reset to prevent stale merging after load layout changes. |
| src/mechaphlowers/api/section_study.py | Ensures set_loads() refreshes the intermediate warm-start state (memento) after loads are updated. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: GOELLER Adrien <adrien.goeller@rte-france.com>
Signed-off-by: GOELLER Adrien <adrien.goeller@rte-france.com>
Signed-off-by: GOELLER Adrien <adrien.goeller@rte-france.com>
Signed-off-by: GOELLER Adrien <adrien.goeller@rte-france.com>
Signed-off-by: GOELLER Adrien <adrien.goeller@rte-france.com>
Signed-off-by: GOELLER Adrien <adrien.goeller@rte-france.com>
Signed-off-by: WANG Jérémy <jeremy.wang@rte-france.com>
Signed-off-by: GOELLER Adrien <adrien.goeller@rte-france.com>
Signed-off-by: GOELLER Adrien <adrien.goeller@rte-france.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
Bugfix: set_loads now store loads in memento
Fix a bug where climage + loads will not affect loads
Also fix bug to allow changing the number of loads