This repository was archived by the owner on Sep 9, 2026. It is now read-only.
closeout: fix #325 stale drive-test note; mark the REDESIGN program complete - #343
Merged
Merged
Conversation
…ssertion (#325) TestDesignDriveStageCatalogP127's doc comment ended with a "Tracked in #300. Until it is settled, asserting either value here would dress a coin-flip as a golden" note — residue from before #300 was settled. It contradicted the body of its own comment block (which explains why BOTH catalogs must hold the cell) and the test itself (which asserts the Modified /2 cell at the case table). Left in place it was the exact sentence a re-opener of the twice-mis-resolved p.300 ruling would cite as authority, sitting in the file they would edit. Delete the two lines. The protected `/2` assertion is unchanged and both redundant catalogs still pass. Also qualify CLAUDE.md's unconditional "never re-introduce an mcr == 0-style sentinel" — P134 legitimately carries one for non-reproducible rows, with the Modified cell corroborated in the separate exact-cost loop; the prohibition is against sentinelling away the /2 reading. Closes #325 Co-Authored-By: Claude Claude-Session: https://claude.ai/code/session_01CnrrDqfE9MFUYxc1YZfGbz
All seven structural findings are resolved. Update the Status table: §2 (#327) and §6 (#331) move from partial to done — the full Second Survey record codec + byte-identical sector save/load landed (PRs #337/#341), and career.go was split into five concern files (PRs #339/#342). Both issues are closed against their deferred remainders in other epics (#195 .sec import, #185 Species). The §4-general primitive tier stays unstarted by design — the next chapter, built when a Maker forces it. Co-Authored-By: Claude Claude-Session: https://claude.ai/code/session_01CnrrDqfE9MFUYxc1YZfGbz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the REDESIGN wave program: one live bug fix plus the doc/status closeout.
#325 — the stale pre-#300 note (bug)
TestDesignDriveStageCatalogP127's doc comment carried a leftover "Tracked in #300. Until it is settled, asserting either value here would dress a coin-flip as a golden" — residue from before the p.300 drive-cost ruling was settled. It contradicted its own comment block (which argues both catalogs must hold the Modified/2cell) and the test itself (which asserts that cell). Left in place, it was the exact sentence a re-opener of the twice-mis-resolved ruling would cite as authority — in the file they'd be editing. The repo's signature fail-open defect, in its most expensive spot.drive_test.go). The protected/2assertion is unchanged; both deliberately-redundant catalogs still pass.{Modified, …, "=7.5"}case still stands,grep dress→ 0,TestDesignDriveStageCatalogP127/P134both PASS.mcr == 0-style sentinel" —P134legitimately carries one for rows whose printed cost isn't reproducible under the final-tonnage rule, with the Modified cell corroborated in the separate exact-cost loop. The prohibition is against sentinelling away the/2reading, not against that mechanism. (The issue's "worth a look while in there.")REDESIGN.md — program complete (docs)
All seven structural findings resolved. Updated the Status table: §2 (#327) and §6 (#331) move partial → done (record codec + byte-identical sector save/load in PRs #337/#341;
career.gosplit in PRs #339/#342). Both issues are being closed against their deferred remainders in other epics — bare references, no closing keyword: T5SS.secimport → #195,SpeciesonCharacter→ #185. The §4-general primitive tier (geom/#176, Money) stays unstarted by design.Review
Closes #325
https://claude.ai/code/session_01CnrrDqfE9MFUYxc1YZfGbz