Add CodeFixer for NoProtectedFieldsAnalyzer (PH2070) - #947
Draft
Brian Collamore (bcollamore) with Copilot wants to merge 3 commits into
Draft
Brian Collamore (bcollamore) with Copilot wants to merge 3 commits into
Brian Collamore (bcollamore) with Copilot wants to merge 3 commits into
Conversation
Co-authored-by: bcollamore <57269455+bcollamore@users.noreply.github.com>
Co-authored-by: bcollamore <57269455+bcollamore@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Create CodeFixer for NoProtectedFieldsAnalyzer
Add CodeFixer for NoProtectedFieldsAnalyzer (PH2070)
Aug 25, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR implements an automatic code fix for the NoProtectedFieldsAnalyzer (PH2070) that converts protected fields to protected properties with private setters, improving code encapsulation.
What's Changed
New CodeFixProvider
[ExportCodeFixProvider]and[Shared]attributesWellKnownFixAllProviders.BatchFixerfor fixing multiple violations at onceSmart Field-to-Property Conversion
The code fix transforms protected fields following C# naming conventions:
Key Features
protected string _a, _b;get; private set;to maintain proper encapsulationEnhanced Test Coverage
NoProtectedFieldsAnalyzerTestto extendCodeFixVerifierDocumentation Update
Documentation/Diagnostics/PH2070.mdto reflect CodeFix availability (changed "No" to "Yes")Benefits for Developers
Testing
The implementation follows the established patterns in the codebase and maintains backward compatibility while adding the requested automatic fix functionality.
Fixes #946.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.