Repository navigation
chore(deps): update dependency eslint-plugin-solid to v0.18.1 - #1145
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.18.0→0.18.1Release Notes
solidjs-community/eslint-plugin-solid (eslint-plugin-solid)
v0.18.1Compare Source
Bug-fix patch release. Thanks @thedanchez for the detailed reports (#233, #234, #235), @brenelz for #230, and @milomg for #228.
solid/reactivity
dynamic()sources from@solidjs/webare now tracked scopes, likecreateMemo— async sources included (#230 by @brenelz; fixes item 1 of #235).{ onDrag: props.onDrag ? (e) => props.onDrag(e) : undefined }) now classify like the unconditional property form instead of reportingbadUnnamedDerivedSignal(#235 item 2)..then()/.catch()/.finally()callbacks are treated as called functions, like timer callbacks and code afterawait(#235 item 3).solid/no-unused-signal
createSignal(fn),createStore(fn, seed)) are no longer reported as "never written" — they change through their source function (#234).export function Component() {}are checked again;export const [a, setA] = createSignal(0)stays exempt (#234).Types
defineConfig()fromeslint/config: the plugin's rules are declared with a loose structural type at the export boundary (mirroring typescript-eslint's workaround for typescript-eslint#11543), and configs validate against ESLint's ownLinter.Config. Runtime unchanged; a type-level test now guards this in CI (#233).eslint-solid-standalone
Linterinstance setscwd: "/", needed by solid-playground (#228 by @milomg).Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.