Skip to content

setRepoSupportedBrands should check supported brands in package.json #462

Description

@marlitas

While deploying a pH Scale RC I was surprised to find that while getBrands.ts checks the brands option against the release branch package.json the same is not done in setRepoSupportedBrands.js against the package.json on main. @zepumph suggested I create an issue and assign him.

This is the code running the check in getBrands.ts

brands.forEach( brand => assert( supportedBrands.includes( brand ), `Unsupported brand: ${brand}` ) );

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions