fix: return checksums from CopyObject - #70
Merged
Conversation
Signed-off-by: Feng Ruohang <rh@vonng.com>
Vonng
force-pushed
the
codex/fix-copyobject-response-checksum
branch
from
August 24, 2026 12:46
1d454e7 to
5d215dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
SILO stored CopyObject checksums and exposed them through HEAD/GET, but the successful CopyObject XML contained only LastModified and ETag. AWS CopyObjectResult defines the checksum elements, and SDK callers expect them when the destination has a checksum.
This response-contract fix is deliberately separate from #66, which corrected the byte domain covered by the stored checksum.
Downstream
Active minio-go also drops these XML elements because its private copyObjectResult contains only ETag and LastModified. The client follow-up is tracked upstream as minio/minio-go#2294.
MCLI and SILO Console require no direct changes: MCLI ignores CopyObject UploadInfo, while Console only passes it through.
Verification
Fixes #68