Add docs for spock.sub_alter_options()#495
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR adds documentation for the Changesspock.sub_alter_options() Documentation
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Up to standards ✅🟢 Issues
|
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/spock_functions/index.md`:
- Line 40: The table row for spock.sub_alter_options is missing the trailing
pipe causing markdownlint MD055 failures; update the table line containing
"[spock.sub_alter_options](functions/spock_sub_alter_options.md) | Change one or
more subscription options in a single atomic operation." to include a trailing
"|" so the row ends with "...operation. |" (i.e., add the final pipe to the row
for spock.sub_alter_options).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a9bf03a6-339b-4f11-b1e4-93706cf510e2
📒 Files selected for processing (3)
docs/spock_functions/functions/spock_sub_alter_options.mddocs/spock_functions/index.mddocs/spock_functions/sub_mgmt.md
| | [spock.sub_wait_for_sync](functions/spock_sub_wait_for_sync.md) | Pause until the subscription is synchronized. | ||
| | spock.sub_alter_skiplsn | Skip transactions until the specified lsn. | ||
| | spock.sub_alter_sync | Synchronize all missing tables. | ||
| | [spock.sub_alter_options](functions/spock_sub_alter_options.md) | Change one or more subscription options in a single atomic operation. |
There was a problem hiding this comment.
Fix table pipe style on this new row.
Line 40 is missing the trailing |, which matches the MD055 warning and can break markdownlint checks.
Suggested fix
-| [spock.sub_alter_options](functions/spock_sub_alter_options.md) | Change one or more subscription options in a single atomic operation.
+| [spock.sub_alter_options](functions/spock_sub_alter_options.md) | Change one or more subscription options in a single atomic operation. |📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| | [spock.sub_alter_options](functions/spock_sub_alter_options.md) | Change one or more subscription options in a single atomic operation. | |
| | [spock.sub_alter_options](functions/spock_sub_alter_options.md) | Change one or more subscription options in a single atomic operation. | |
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 40-40: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/spock_functions/index.md` at line 40, The table row for
spock.sub_alter_options is missing the trailing pipe causing markdownlint MD055
failures; update the table line containing
"[spock.sub_alter_options](functions/spock_sub_alter_options.md) | Change one or
more subscription options in a single atomic operation." to include a trailing
"|" so the row ends with "...operation. |" (i.e., add the final pipe to the row
for spock.sub_alter_options).
Source: Linters/SAST tools
danolivo
left a comment
There was a problem hiding this comment.
forward_origins
A JSON array of origin names whose transactions the subscriber
should forward.
The direction is inverted: nothing "forwards" on the subscriber side; the option controls which changes this subscription applies/receives based on their origin.
Summary
docs/spock_functions/functions/spock_sub_alter_options.md— full reference page covering synopsis, return values, all three options (forward_origins,apply_delay,skip_schema), validation rules, and examplesspock.sub_alter_optionsto the function table indocs/spock_functions/sub_mgmt.mddocs/spock_functions/index.mdThe function was introduced in 6.0.0 (noted in the release notes) but had no reference documentation.
Test plan
tests/regress/sql/alter_options.sql🤖 Generated with Claude Code