Use document filename as browser tab title - #36
Open
NuclearManatee wants to merge 1 commit into
Open
Conversation
Use state.page.filename (already computed by pageState()) to set document.title so browser tabs show which document is open instead of all showing 'human review'. Closes petergyang#24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reviewing multiple documents, all browser tabs showed
"human review" — you couldn't tell which tab had which document.
This sets document.title to the filename already computed by
pageState() (e.g. index.html, README.md, or the URL pathname),
falling back to 'human-review' when no page is loaded.
Change: 1 line in src/chrome-client.js render().
Closes #24