Almost Complete rewrite - #8
Open
ross-m-dickson wants to merge 25 commits into
Open
Conversation
added 25 commits
August 13, 2021 12:16
… prior to exit, moved activation of monitor thread from main function into object, added debug printouts
…ns prior to exit, moved initialization of state from main function into object, added debug printouts
…ns prior to exit, moved initialization of state from main function into object, added debug printouts
…channel mutes and the two layer buttons to select the bank controlled by encoders
…and monitor levels for all channels.
…le and to restructure the way state is stored to be more flexible
…umenting file format
Owner
|
Thanks for this contribution. I just came back from a vacation and will look at this in the next days. But as this is basically a complete rewrite, I'm not sure I want to merge it into this repository. I will try it and see if I feel comfortable supporting your code and decide then. I will keep you posted. |
Author
|
I figured there was a good chance you wouldn’t want to merge it in but thought you would be interested either way. I hope the vacation was a good one. If you decide not to merge I’ll add to the copyright that this is a fork but other wise keep attribute as shown in the pull request.
… On Sep 14, 2021, at 10:33 AM, peterdikant ***@***.***> wrote:
Thanks for this contribution. I just came back from a vacation and will look at this in the next days. But as this is basically a complete rewrite, I'm not sure I want to merge it into this repository. I will try it and see if I feel comfortable supporting your code and decide then. I will keep you posted.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#8 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATMRD7JJQ6E22JLJ55IGJRLUB5MJ3ANCNFSM5DPDRHDQ>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Owner
|
Impressive changes. This is really a full rewrite. Good work. I will not merge your changes because I don't feel comfortable being responsible for a project where most of the code is not mine. So please publish it under your own account and I will link to your project from the README file. So anyone who needs a fully configurable solution will be redirected to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is essentially a complete rewrite of all aspects of the code to move the configuration of which buttons control what from being embedded in the logic to being in separate config files. Feel free to disregard, while I think I have preserved all aspects of the original functionality, I've not done an A/B on every possible control and mode combination. I have unit tested every control for each of the config files.