Remove deprecated functions (validate_legacy, hiera_hash, is_hash and has_key) - #99
Remove deprecated functions (validate_legacy, hiera_hash, is_hash and has_key)#99lcharreau wants to merge 5 commits into
validate_legacy, hiera_hash, is_hash and has_key)#99Conversation
|
Fixes #90 |
lcharreau
changed the title
validate_legacy and hiera_hash)validate_legacy, hiera_hash, is_hash and has_key)
siebrand
left a comment
siebrand
left a comment
There was a problem hiding this comment.
There is one error in your PR, and puppet-lint -f will fix the other issues that prevent using this module with puppet 8.
You can take siebrand@d0d18e2 if you like.
| validate_legacy(String, 'validate_re', $ensure, ['^absent$', '^present$']) | ||
| validate_legacy(String, 'validate_string', $swapfile) | ||
| Enum['present','absent'] $ensure = 'present', | ||
| Stdlib::Absolutefile $swapfile = '/mnt/swap.1', |
There was a problem hiding this comment.
Should be Stdlib::Absolutepath. Module with this PR applied throws an error:
Error: Resource type not found: Stdlib::Absolutefile
There was a problem hiding this comment.
Ok thanks for your feedback. I fixed the reported errors using pdk bundle exec rake lint_fix (for Puppet8).
|
Hello, metadata.json requirements for stdlib should be revved to >= 9.6.0 Thaks, -mp |
|
@mvphilip this module was migrated to Vox Pupuli: https://github.com/voxpupuli/puppet-swap_file |
|
@kenyon Any idea when it will be published on puppet forge for the first time? |
4 participants
Since stdlib version 9.x, the
validate_legacy,is_hashandhas_keyfunctions have been deprecated.The
hiera_hashfunction is also deprecated (I've replaced it with thelookupfunction with the 'hash' merge strategy).