Fix bare fade token floating above neighbors in Advanced label - #7
Merged
Conversation
When all edges are enabled the class collapses to a single `fade`, whose token has an empty prefix part (no `fade-…-` segment). As an inline-flex box, the token derived its baseline from that empty first flex item and floated ~7px above the other tokens on the line. Add `align-items: baseline` to `.fade-option-token` so the prefix/stem parts align on their text baseline and the token reports a glyph baseline to the line — correct for every token, empty-prefix or not. Verified across bare-fade, fade-y, fade-x, and 3-edge label states: all tokens share one top (0px spread). Claude-Session: https://claude.ai/code/session_01B1Gn7DoGHbzGCLMbA72Stj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When all edges are enabled the Advanced label's class collapses to a single
fade, whose token has an empty prefix part. As aninline-flexbox, the token derived its baseline from that empty first flex item and floated ~7px above the other tokens on the line.Fix:
align-items: baselineon.fade-option-token— the prefix/stem parts align on their text baseline, so the token reports a glyph baseline to the line (correct for every token, empty-prefix or not).Verified across bare-fade, fade-y, fade-x, and 3-edge label states: all tokens share one top (0px spread).
https://claude.ai/code/session_01B1Gn7DoGHbzGCLMbA72Stj