Remove unused client message helpers from public API (#202)#203
Merged
Conversation
msk
approved these changes
May 30, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
=======================================
Coverage 85.61% 85.61%
=======================================
Files 15 15
Lines 6481 6481
=======================================
Hits 5549 5549
Misses 932 932 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the public re-exports of the
send_err,send_ok, andsend_requesthelpers from theclientmodule. These symbols werere-exported from
oinq::messagebut are no longer used by clients,so keeping them public only widened the crate's public API surface.
What changed
pub use oinq::message::{send_err, send_ok, s send_request};so the helpers are no longer part of the public API.pointed users to the typed
client::ConnectionAPIs instead.Why
Clients don't use these helpers anymore. Keeping unused re-exports in
the public API makes the crate harder to maintain and increases
backwards-compatibility burden. Internal code that needs the helpers
continues to reference
oinq::messagedirectly.Verification
Files changed
Closes #202