fix: match physical layout include order with blecorne board - #31
Merged
perrwa merged 1 commit intoMay 20, 2026
Merged
Conversation
The dongle overlay included 5column.dtsi before 6column.dtsi, while the blecorne board definition includes them in the opposite order. ZMK's physical layout system enumerates layouts by DTS definition order, so when the central sends its selected layout INDEX to peripherals, the peripheral resolves a different layout. Dongle (was): layouts[0]=5col, layouts[1]=6col → selects 6col → sends idx 1 Blecorne: layouts[0]=6col, layouts[1]=5col → receives idx 1 → selects 5col! This caused the peripheral to use the 5-column transform (stride 10) instead of the 6-column transform (stride 12), scrambling every key position sent to the central. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the key position scramble when using blecorne halves as BLE peripherals to the Raytac dongle central.
Root cause: The dongle overlay included
5column.dtsibefore6column.dtsi, but the blecorne board definition includes them in the opposite order. ZMK enumerates physical layouts by DTS definition order, so when the central sends its selected layout index to peripherals viaSET_PHYSICAL_LAYOUT, the peripheral resolves a different layout—selecting the 5-col transform (stride 10) instead of 6-col (stride 12), which scrambles every position.Fix: Swap the include order in the dongle overlay to match blecorne (6col first, 5col second). Now both sides have
layouts[0]=6col,layouts[1]=5col.