fix: apt-get flag, schema typos, install_files error handling, port max#121
Merged
Conversation
--assumeyes is a dnf/yum flag, not valid for apt-get. apt-get already has -y which serves the same purpose. The invalid flag would cause apt-get to fail on Debian/Ubuntu-based userenvs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Three instances of "uniqueuItems" (extra 'u') were silently ignored by JSON Schema validators, allowing duplicate items in distro-manual_info.packages, distro_info.packages, and distro_info.groups arrays. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Every other install_* function calls sys.exit() on failure, but install_files logged errors and continued. A failed buildah add would silently produce an image with missing files. The missing-destination branch is a defense-in-depth guard — the schema requires dst — but should still exit if somehow reached. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Valid TCP/UDP port range is 1-65535. Port 65536 is not a valid port number. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
tc-wilson
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four fixes, one per commit:
Remove
--assumeyesfrom apt-get:--assumeyesis a dnf/yum flag, not valid for apt-get (which already has-y). Would cause group install/remove to fail on Debian/Ubuntu userenvs.Fix misspelled
uniqueuItemsin schema: Three instances of"uniqueuItems"(extrau) silently ignored by validators. Duplicate items indistro-manual_info.packages,distro_info.packages, anddistro_info.groupsarrays were not rejected.Exit on
install_filesfailure: Every otherinstall_*function callssys.exit()on failure, butinstall_fileslogged errors and continued — silently producing images with missing files. The missing-destination guard is defense-in-depth (schema requiresdst).Port maximum 65536 → 65535: Valid TCP/UDP port range is 1-65535.
Closes #120
Test plan
python3 -c "import json; json.load(open('schema.json'))"— valid JSON--assumeyesinstall_filesexit behavior matches otherinstall_*functions🤖 Generated with Claude Code