fix: misspelled uniqueItems, duplicate test methods, and test fixture#107
Open
k-rister wants to merge 3 commits into
Open
fix: misspelled uniqueItems, duplicate test methods, and test fixture#107k-rister wants to merge 3 commits into
k-rister wants to merge 3 commits into
Conversation
"uniqeueItems" is silently ignored by JSON Schema validators, so duplicate items in the sets array were not rejected. Closes: #105 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Duplicate "include" keys in JSON objects cause the first to be silently overwritten — "common-params" was never included. Use the array form to include both groups. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- test-json.py: remove duplicate test_multi_params_sets (second
definition shadowed the first, making the first dead code)
- test-requirements.py: rename duplicate test_create_validation_dict
to test_create_validation_dict_single_escape (tests a different
scenario — single-escape regex failure)
- test-requirements.py: change "is not {}" to "!= {}" — identity
check against a new dict literal always passes
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uniqeueItems→uniqueItemsin schema.json — misspelling silently disabled duplicate rejection"include"keys in fio-multi-params-test.json — use array form to include both groupstest_multi_params_setsin test-json.py (second shadowed first)test_create_validation_dictin test-requirements.py totest_create_validation_dict_single_escapeis not {}→!= {}— identity check against a new dict literal always passesCloses #105
Test plan
pytest tests/passes🤖 Generated with Claude Code