fix: undefined vars, regex bugs, sourceType crash, and typos#197
Open
k-rister wants to merge 6 commits into
Open
fix: undefined vars, regex bugs, sourceType crash, and typos#197k-rister wants to merge 6 commits into
k-rister wants to merge 6 commits into
Conversation
The warning referenced undefined docTypes and numAttempts instead of the in-scope numDocTypes returned by waitForDeletedDocs(). Closes: #195 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
info['indices'] does not exist — the indices are nested under info['runIds'][runId]['indices'] as used on the surrounding lines. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sourceType[1] was undefined when the primary metric name did not contain a :: separator, matching the guard already present earlier in the same file (lines 363-371). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
[7|8|9] matches digits 7, 8, 9 AND the literal pipe character. Use [789] for the intended behavior. Affected 7 files. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
index-nane, porse, vaules, greather, mestric_desc-uuid, retured, reqsuested, interations, soucres Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docTypesandnumAttemptsin warning message — usenumDocTypesinfo['indices']— should beinfo['runIds'][runId]['indices']::separator —sourceType[1]was undefinedeopch_ms→epoch_msandotuput→outputtypos in help text[7|8|9]→[789]in CDM version check — was also matching literal pipeindex-nane,porse,vaules,greather,mestric_desc-uuid,retured,reqsuested,interations,soucresCloses #195
Test plan
node queries/cdmq/delete-run.js --help— no syntax errorsnode queries/cdmq/add-run.js --help— no syntax errors🤖 Generated with Claude Code