Skip to content

test: remove molecule - #93

Merged
richm merged 1 commit into
performancecopilot:mainfrom
richm:test-remove-unused
Jun 26, 2026
Merged

test: remove molecule#93
richm merged 1 commit into
performancecopilot:mainfrom
richm:test-remove-unused

Conversation

@richm

@richm richm commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

molecule is not used

Signed-off-by: Rich Megginson rmeggins@redhat.com

molecule is not used

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6e021081-6956-4d70-8354-d48b1dcdbef6

📥 Commits

Reviewing files that changed from the base of the PR and between ae9851d and bebede4.

📒 Files selected for processing (2)
  • molecule/default/Dockerfile.j2
  • molecule/default/molecule.yml
💤 Files with no reviewable changes (2)
  • molecule/default/Dockerfile.j2
  • molecule/default/molecule.yml

📝 Walkthrough
  • Removed the unused Molecule test configuration from molecule/default/, including the Dockerfile template and scenario definition.
  • Eliminated the Molecule setup that previously handled multi-distro container provisioning, Ansible test execution, and idempotence/check steps.

Walkthrough

Two files under molecule/default/ are deleted: Dockerfile.j2, which templated multi-distro Python/sudo provisioning, and molecule.yml, which configured a Galaxy driver, three CentOS platforms, an Ansible provisioner, and a default test sequence.

Changes

Cohort / File(s) Summary
Remove Molecule default scenario
molecule/default/Dockerfile.j2, molecule/default/molecule.yml
Both files are entirely deleted. Dockerfile.j2 provided a multi-package-manager Python/sudo install template; molecule.yml declared CentOS 6/7/8 privileged systemd platforms, a Galaxy driver, provisioner path, and a six-step test sequence.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A Dockerfile gone, a molecule too,
No more CentOS containers to brew,
The rabbit hops past with a flick of its ear,
"Less config to chase!" it says with good cheer,
The defaults are swept, the scenario clear. 🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is on-topic but missing the required Enhancement, Reason, Result, and Issue Tracker Tickets sections. Fill in the template sections with the removal rationale, expected result, and any Jira/BZ ticket references.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: removing Molecule test files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@richm
richm requested a review from sfeifer June 24, 2026 13:40
@richm

richm commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

@sfeifer I'm trying to reduce the footprint for security scanners by removing unused code - we are getting false positives for other system roles

@richm

richm commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

@sfeifer any objection to merging?

@sfeifer

sfeifer commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

No objections. Looks good to me.

@richm
richm merged commit 107e0d3 into performancecopilot:main Jun 26, 2026
5 of 7 checks passed
@richm
richm deleted the test-remove-unused branch June 26, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants