Skip to content

fix: avoid double restart of pmlogger on config changes #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richm merged 1 commit into from
Jun 9, 2026
Merged

fix: avoid double restart of pmlogger on config changes #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions roles/pcp/handlers/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,3 @@
name: pmproxy
state: restarted
when: __pcp_is_booted | bool

- name: Restart pmlogger
service:
name: pmlogger
state: restarted
when: __pcp_is_booted | bool
2 changes: 0 additions & 2 deletions roles/pcp/tasks/pmlogger.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
dest: "{{ __pcp_pmlogger_timers_path }}"
mode: "0644"
register: __pcp_register_changed_logging_retention_period
notify: Restart pmlogger

- name: Enable performance metric logging for targeted hosts (with control.d)
template:
Expand All @@ -31,7 +30,6 @@
mode: "0644"
loop: "{{ pcp_target_hosts | default([]) }}"
register: __pcp_register_changed_targeted_hosts_controld
notify: Restart pmlogger
when:
- not pcp_single_control | d(false) | bool
- pcp_target_hosts | d([]) | length > 0
Expand Down
Loading