feat: add support for AlmaLinux distribution - #91
Merged
Conversation
Contributor
|
This is only for the pcp "subrole". What about the other subroles such as bpftrace, grafana, etc.? |
Contributor
Author
|
Fair point, I added the configs for the other roles as well. |
sfeifer
approved these changes
Apr 10, 2026
sfeifer
left a comment
sfeifer
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me.
The Ansible Lint and Markdown Lint checks look to be failing for some time now. Don't think it has anything to do with this PR, but are there some future plans to fix those?
Contributor
No, not with this PR, just bit rot.
These get tested as part of the metrics system role, so not a high priority, but yeah, we should fix them at some point. |
richm
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhancement:
Add support for AlmaLinux.
Reason:
The role failed on AlmaLinux because vars were not set.
Result:
AlmaLinux is now supported.