Require per-app SES emails and multi-identity IAM - #6
Merged
Conversation
… IAM. Drop stack NotificationEmail/FromEmail; allow multiple SES identities via SES_IDENTITIES and fail deploy when apps YAML or From coverage is invalid. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notificationEmail/fromEmailper app in the apps registry; remove stack-levelNOTIFICATION_EMAIL/FROM_EMAIL/WELES_SES_*SES_IDENTITIES→SesIdentityArns(CommaDelimitedList) for Lambda IAMdeploycheckso CI validates apps YAML and From coverage before SSM publish / SAM deployTest plan
go test ./...go run ./cmd/deploycheck -apps config/apps.example.yaml -identities example.com -print-arns …sam validate --lintSES_IDENTITIESand updateAPPS_CONFIGwith emails before merge/deployNOTIFICATION_EMAIL/FROM_EMAILGET /healthzand one feedback submit after deployMade with Cursor