Conversation
There is really no reason why a C compiler should be part of our base image. Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
This does not matter in practice, but I think it looks clever. Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
Member
Author
|
I have changed the config to only set the |
jluebbe
requested changes
Jun 29, 2026
hnez
force-pushed
the
lgo/tpm
branch
2 times, most recently
from
June 29, 2026 08:39
f14ac94 to
66dc942
Compare
This enables us to log into hosts via SSH without exposing the private key to the running jobs. The tpm2-pkcs11 provider prints error messages when no store is set up, so only use it when one is present. Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
jluebbe
approved these changes
Jun 29, 2026
jluebbe
left a comment
jluebbe
left a comment
Member
There was a problem hiding this comment.
Looks good to me, but note I've not tested this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables us to log into hosts via SSH without exposing the private key to the running jobs.
This has become possible with the merge of forrest-runner/forrest#49.