New addition to this repo#29
Open
rohit366 wants to merge 9 commits into
Open
Conversation
rohit366
commented
Aug 29, 2023
rohit366
commented
Contributor
- New addition to improve collapsible guide layout.
- Added a new ability to trigger another guide based on standard snooze action in the first guide using dynamic permalink.
Latest update to collapsible guide designs to give more flexibility and choices.
updated.
New option to use standard snooze controls with the ability to launch another guide on any page you like
Contributor
Author
|
@fortynachos please review the latest additions. |
Contributor
Author
|
@fortynachos can you please review this. |
|
Thanks @rohit366 for this pr. I found issues with the existing code where the collapsed guide still left an invisible element on the screen, preventing users from clicking anything behind it. Update: I tried your version of the code but the bug remains. When the guide step is minimised the text on the page behind it is unclickable, as the div is still on-screen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.