Skip to content

Stub the Vite manifest in tests so CI does not need a frontend build - #2544

Merged
lancepioch merged 1 commit into
mainfrom
test/without-vite
Aug 25, 2026
Merged

Stub the Vite manifest in tests so CI does not need a frontend build#2544
lancepioch merged 1 commit into
mainfrom
test/without-vite

Conversation

@lancepioch

@lancepioch lancepioch commented Aug 25, 2026

Copy link
Copy Markdown
Member

The file upload manager tests from #2540 render real server pages, which hit the @vite directive. CI test jobs never build the frontend, so every SQLite/MySQL/Postgres test job fails with "Vite manifest not found". Calling withoutVite() in the base TestCase stubs the directive for all tests.

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f7661913-b6f4-48b0-ad25-ee3fe8bb03f0

📥 Commits

Reviewing files that changed from the base of the PR and between e5a24e5 and 4b126e1.

📒 Files selected for processing (1)
  • tests/TestCase.php

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The test base class now disables Vite during setUp(). Rendered views no longer require a Vite manifest when the frontend build is skipped.

Changes

Test environment setup

Layer / File(s) Summary
Disable Vite during test setup
tests/TestCase.php
setUp() calls $this->withoutVite() before tests run.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the main change: stubbing the Vite manifest requirement in tests so CI does not need a frontend build.
Description check ✅ Passed The description directly explains the CI failure, the missing Vite manifest, and the use of withoutVite() to resolve the issue across database test jobs.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lancepioch lancepioch self-assigned this Aug 25, 2026
@lancepioch
lancepioch merged commit e832ebe into main Aug 25, 2026
17 checks passed
@lancepioch
lancepioch deleted the test/without-vite branch August 25, 2026 00:30
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant