Run the Filament tests in CI - #2541
Conversation
tests/Filament was not in any phpunit testsuite and no CI job ran it, so the panel and authorization tests have never executed anywhere. Unsurprisingly they had rotted: ListNodesTest and ListEggsTest were referencing an undefined Permission class, calling a factory Spatie's Permission model does not have, resolving action urls against the default app panel rather than admin, and asserting a toolbar action as if it were a record action. Fix the seven failures, add a Filament testsuite and run it from the sqlite job. These are panel tests with nothing database specific in them, so there is no reason to repeat them across the mysql, mariadb and postgres matrices.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe PR registers the Filament PHPUnit suite, adds it to SQLite CI execution, and standardizes Filament admin panel and permission setup in node and egg tests. The node test also verifies the table create action by name. ChangesFilament test coverage
Merge Risk: ⚪ Minimal · up to The PR adds the Filament tests to CI and corrects their test setup and assertions; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 participants
tests/Filamentwasn't in any phpunit testsuite and no CI job ran it, so those tests have never actually executed. They'd rotted in the meantime:ListNodesTestandListEggsTestreferenced an undefinedPermissionclass, called a factory Spatie's model doesn't have, resolved action urls against the defaultapppanel instead ofadmin, and asserted a toolbar action as if it were a record action.Fixed the seven failures, added a
Filamenttestsuite and ran it from the sqlite job. Nothing in them is database specific so there's no reason to repeat them across the mysql, mariadb and postgres matrices.