Skip to content

hierarchy_fix: handle case where the placetype changed #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
missinglink merged 1 commit into from
Jul 8, 2020
Merged

hierarchy_fix: handle case where the placetype changed #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions sqlite/fix.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,13 @@ const table = {
}

// return a map where the key is the ID of a superseded
// record and the value is the replacement ID
// record and the value is an object containing the
// replacement ID & the replacement placetype.
function findSuperseded (db) {
const stmt = db.prepare(`
SELECT
id,
json_extract(geojson.body, '$.properties."wof:placetype"') AS placetype,
json_extract(geojson.body, '$.properties."wof:supersedes"') AS supersedes
FROM geojson
WHERE is_alt = 0
Expand All @@ -22,7 +24,8 @@ function findSuperseded (db) {
for (const row of stmt.iterate()) {
const supersedes = JSON.parse(row.supersedes)
if (!_.isArray(supersedes) || _.isEmpty(supersedes)) { continue }
supersedes.forEach(id => superseded.set(id, row.id))
const identity = { id: row.id, placetype: row.placetype }
supersedes.forEach(id => superseded.set(id, identity))
}

return superseded
Expand Down Expand Up @@ -97,8 +100,8 @@ module.exports.hierarchies = (db, options) => {
const parentID = feature.getParentId(feat)
if (superseded.has(parentID)) {
const replacement = superseded.get(parentID)
console.error(`${id} has an incorrect parent_id, replacing ${parentID} with ${replacement}`)
_.set(feat, 'properties.wof:parent_id', replacement)
console.error(`${id} has an incorrect parent_id, replacing ${parentID} with ${replacement.id}`)
_.set(feat, 'properties.wof:parent_id', replacement.id)
reindex = true
}

Expand All @@ -109,8 +112,13 @@ module.exports.hierarchies = (db, options) => {
if (hierarchyId === id) { return } // do not update self-references
if (superseded.has(hierarchyId)) {
const replacement = superseded.get(hierarchyId)
console.error(`${id} has an incorrect ${key}, replacing ${hierarchyId} with ${replacement}`)
_.set(feat, `properties.wof:hierarchy[${branch}][${key}]`, replacement)
const replacementKey = `${replacement.placetype}_id`
console.error(`${id} has an incorrect ${key}, replacing ${hierarchyId} with ${replacementKey}=${replacement.id}`)

// handle the case where the placetype changed when superseded
if (key !== replacementKey) { _.unset(feat, `properties.wof:hierarchy[${branch}][${key}]`) }

_.set(feat, `properties.wof:hierarchy[${branch}][${replacementKey}]`, replacement.id)
reindex = true
}
})
Expand Down