Removed dulicate saveScreenshots func - #362
Draft
enes-0 wants to merge 1 commit into
Draft
Conversation
-Removed parallel comparison
enes-0
marked this pull request as draft
April 14, 2026 10:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
!!!Not finalized!!!
-Removed parallel comparison
📌 References
🎩 What is the goal?
Fix heap memory issues in the Shot library that occur when running screenshot tests with large image differences, causing OutOfMemoryError.
How is it being implemented?
ScreenshotsSaver.saveTemporalScreenshots: Previously,saveScreenshotswas called twice — once to save to the temporal path and effectively again to save to the report folder. Replaced the secondsaveScreenshotscall withFileUtils.copyDirectory, which copies the already-written files to the report folder instead of recomposing and re-encoding all screenshots into memory a second time.ScreenshotsComparator.compare: Changedscreenshots.par.flatMap(...)toscreenshots.flatMap(...), removing parallel collection usage. Parallel comparison loads multiple screenshot pairs into memory simultaneously, which multiplies heap usage. Sequential comparison processes one screenshot at a time, trading execution speed for significantly lower peak memory consumption.How can it be tested?
If it cannot be tested explain why.
executeScreenshotTests -Precord)executeScreenshotTests) and confirm the report folder contains the expected images.