Repository navigation
fix: wrap errors with %w in s3 storage - #885
Open
terryrankine wants to merge 1 commit into
Open
terryrankine wants to merge 1 commit into
terryrankine wants to merge 1 commit into
Conversation
Use %w instead of %v in fmt.Errorf for the endpoint parsing and region fetching errors so callers can inspect the cause with errors.Is and errors.As. Add a parseEndpoint test that checks an invalid endpoint error unwraps to *url.Error. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
3 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Two returned errors in
storage/s3.gowere formatted with%v, which discards the wrapped error and defeatserrors.Is/errors.Asfor callers.Fix
Use
%winparseEndpointandsetSessionRegion. The debug-only"retryable error: %v"string is untouched since it is never returned.Tests
TestParseEndpoint: parsinghttp://[::1must yield an error thaterrors.Asunwraps to*url.Error. Fails with%v, passes with%w.Linux, Go 1.24,
go test -count=1 -race ./...: all packagesok.gofmt,go vet,staticcheck,unparam,semgrep: clean.🤖 Generated with Claude Code