add route to fetch the current pod count#31
Open
ylebre wants to merge 1 commit into
Open
Conversation
…ves in the config.php.
Potherca
approved these changes
Jun 12, 2026
Potherca
left a comment
Potherca
left a comment
Member
There was a problem hiding this comment.
Code is okay.
Two minor comments. Resolve or ignore at will.
|
|
||
| public static function respondToPodCount() { | ||
| $requestFactory = new ServerRequestFactory(); | ||
| $rawRequest = $requestFactory->fromGlobals($_SERVER, $_GET, $_POST, $_COOKIE, $_FILES); |
Member
There was a problem hiding this comment.
- Dynamic call to static method
ServerRequestFactory::fromGlobals(). - Unused variable
$rawRequest(and$requestFactory).
Was this meant to be used below (instead of $_SERVER?)
| if (sizeof($result) === 1) { | ||
| return $result[0]['podCount']; | ||
| } | ||
| return false; |
Member
There was a problem hiding this comment.
Based on the JSON return of SolidStorageProvider::respondToPodCount, shouldn't this be 0?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fetch it, the request should pass a pod-count-key header that matches the POD_COUNT_KEY constant defined in the config.php;
The endpoint returns a {"count":xxx} json result which can then be used in all kinds of fun graph-things.