Adjust the expected test output to include editables 0.6 - #304
Merged
Conversation
✅ Deploy Preview for pdm-backend-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
hroncok
reviewed
May 22, 2026
hroncok
left a comment
hroncok
left a comment
There was a problem hiding this comment.
What is a benefit of making find_pth_filename a pytest fixture that is a function, rather than having it in test_api.py as a normal function?
frostming
reviewed
May 25, 2026
Contributor
Author
|
The commit has been amended, it's now a normal function in test_api module. |
frostming
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #303
assert pth_filename in namelistis a bit redundant with the fixture, but since explicit is better than implicit, i left it there.