leaderboard function#9
Open
Harlemzino wants to merge 6 commits into
Open
Conversation
…a discord message
pblca
requested changes
Jun 20, 2023
| # Check if the user invoking the command has the 'Serenader' role | ||
| admin = discord.utils.get(interaction.guild.roles, name='Serenader') | ||
| if admin not in interaction.user.roles: | ||
| await interaction.response.send_message('You are not a Serenader') |
Owner
There was a problem hiding this comment.
This should be an ephemeral response. Should probably make an error response class.
Additionally, we should make the role required guild configurable (store this configuration in mongo), or otherwise have the bot check for and make a role if its missing on start up.
Owner
There was a problem hiding this comment.
@Harlemzino Actually, that whole admin check should be elevated to its own class somewhere so we can reuse this in any command that we want gated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.