extract Windows shim launching into tested executable helper - #5
Merged
Conversation
Move the cmd.exe .cmd/.bat shim handling out of extension.ts into a new buildLanguageServerExecutable() in src/executable.ts, now spawning with windowsVerbatimArguments and caret-escaping metacharacters so shim paths with spaces and special characters launch correctly. Add unit tests (node --test) covering shim invocation, escaping, and direct execution, plus a test:unit script. Run the tests in a new reusable Test workflow on ubuntu/windows for PRs, gate release tagging on it, and run it before packaging in the Open VSX workflow. Exclude out/test/** from the VSIX.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the cmd.exe .cmd/.bat shim handling out of extension.ts into a new buildLanguageServerExecutable() in src/executable.ts, now spawning with windowsVerbatimArguments and caret-escaping metacharacters so shim paths with spaces and special characters launch correctly.
Add unit tests (node --test) covering shim invocation, escaping, and direct execution, plus a test:unit script. Run the tests in a new reusable Test workflow on ubuntu/windows for PRs, gate release tagging on it, and run it before packaging in the Open VSX workflow. Exclude out/test/** from the VSIX.