[Flowless.AI] Code improvements

[mozinova]

🔍 Flowless.AI Analysis

This PR was automatically generated by Flowless.AI based on code analysis.

Modified Files (6)

• README.md: Updated README usage example to load API key from environment variable instead of hardcoding it, addressing the critical security risk of credential leakage. Added necessary os import to support this change.
• pyproject.toml: Partially apply dependency pinning: secure pydantic version is confirmed, but requests version is unverified. Maintain loose constraint on requests until authoritative version info is available.
• src/paysgator/client.py: Applied surgical patch to add timeout configuration (30 seconds) to HTTP requests to prevent hangs under network instability. Did not patch API authentication or error message sanitization as these require cross-file changes to exceptions.py and would need additional context verification. Float-to-Decimal conversion for monetary values was not patched as it requires cascading changes across models.py, client.py, and documentation.
• src/paysgator/exceptions.py: Prevents exposure of potentially sensitive error messages in exception strings while preserving the message for internal SDK use (e.g., future logging). This avoids breaking client code that might inspect the exception object directly.
• src/paysgator/models.py: Fixed critical financial precision issues by converting all monetary fields (including balance) to Decimal type, and resolved inconsistent field aliasing to use proper camelCase conventions matching API contract. These changes address security and functional correctness risks identified in the project context.
• test_sdk.py: Three critical fixes: (1) broken import path causing ImportError, (2) hardcoded credentials security vulnerability, (3) incorrect API resource and parameter names causing runtime errors. All changes based on resolved context from README.md, init.py, and client.py.

Summary

README.md:

• ⚠️ api authentication flaws
• ⚠️ insecure deserialization

pyproject.toml:

• ⚠️ loose dependency version constraints may allow incompatible updates
• ⚠️ no explicit security scanning or vulnerability management configured
• ⚠️ external API integration without visible authentication configuration in this file

src/paysgator/init.py:

• ⚠️ api authentication flaws

src/paysgator/client.py:

• ⚠️ API authentication flaws: The client relies solely on an API key in the 'X-Api-Key' header, which may be insufficient for sensitive operations if not paired with additional security measures like IP whitelisting or short-lived tokens.
• ⚠️ Insecure deserialization: Although responses are parsed via Pydantic models (which offer some validation), raw response.text is exposed in APIError exceptions, potentially leaking sensitive data or enabling injection if error messages are rendered unsafely elsewhere.

src/paysgator/exceptions.py:

• ⚠️ APIError exposes status_code and message as public attributes which could leak sensitive error details if not properly sanitized
• ⚠️ No error logging mechanism - errors may not be captured for debugging/monitoring

src/paysgator/models.py:

• ⚠️ Use of float for monetary amounts may lead to precision errors; decimal types are preferred for financial calculations.
• ⚠️ Optional fields like payment_methods and payment_fields use inconsistent aliasing (payment_methods vs payment_fields), which may cause serialization/deserialization mismatches with the API.

test_sdk.py:

• ⚠️ hardcoded API credentials (api_key, wallet_id)
• ⚠️ placeholder values that could be accidentally committed to version control
• ⚠️ empty phoneNumber field in payment_fields configuration
• ⚠️ no error handling around client operations

---

Generated by Flowless.AI • Task ID: f5f1f435-a1af-443d-b6e9-668468056d17