This repository was archived by the owner on Aug 22, 2025. It is now read-only.
Added feature to create third party access tokens#968
Open
anubhavchaturvedi wants to merge 2 commits into
Open
Added feature to create third party access tokens#968anubhavchaturvedi wants to merge 2 commits into
anubhavchaturvedi wants to merge 2 commits into
Conversation
jaypatel512
suggested changes
Oct 31, 2017
jaypatel512
left a comment
jaypatel512
left a comment
Contributor
There was a problem hiding this comment.
These are my comments based on my very limited understanding of subject based on this PR.
| */ | ||
| private $cipher; | ||
|
|
||
| /** |
| $params['grant_type'] = 'refresh_token'; | ||
| $params['refresh_token'] = $refreshToken; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
If subject is associated with a refreshToken, should we just pass the subject as an argument here, instead of adding it to a constructor ?
| $cred = new OAuthTokenCredential('clientId', 'clientSecret', 'subject'); | ||
|
|
||
| //{"clientId":{"clientId":"clientId","accessToken":"accessToken","tokenCreateTime":1421204091,"tokenExpiresIn":288000000}} | ||
| AuthorizationCache::push($config, 'clientId', $cred->encrypt('accessTokenWithSubject'), 1421204091, 288000000); |
Contributor
There was a problem hiding this comment.
If subject is relevant only for third party tokens (refresh tokens), we should not cache the response. This could lead to all consequent calls with just a clientId to use this subject based access token. This will be because, we only fetch this cache by clientId and nothing else.
anubhavchaturvedi
force-pushed
the
thirdPartyChanges
branch
from
November 13, 2017 20:46
4ef45ec to
31f6001
Compare
Rabbi1
approved these changes
Mar 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.