refactor: remove strictDraftTypes flag, make strict draft types the default - #17821
Open
DanRibbens wants to merge 1 commit into
Open
refactor: remove strictDraftTypes flag, make strict draft types the default#17821DanRibbens wants to merge 1 commit into
DanRibbens wants to merge 1 commit into
Conversation
Removes the `strictDraftTypes` typescript config option and always applies strict typing to draft operations. The `draft` parameter is now `never` on collections and globals without drafts, and draft queries return required fields as optional. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typescript.strictDraftTypesconfig option; strict draft typing is now always on (completes the v4 TODO onpackages/payload/src/config/types.ts).draftis nowneveron collections and globals without drafts, and draft-modefind/findByIDresults type required user fields as optional.registerFirstUserwidens its slug toCollectionSlugsince the strictOptionsconditional stays deferred for a naked genericTSlugand can't be routed by TS to a specific branch.Test plan
pnpm --filter payload buildsucceedspnpm run build(all 45 core packages) succeedspnpm run test:types— 212/212 pass across all 9 tstyche projects (types,untyped,queues,database,lexical,plugin-mcp,image-size-options/*,storage-r2)