fix(richtext-lexical): preserve logical text alignment - #17809
Open
ertugakmann wants to merge 1 commit into
Open
fix(richtext-lexical): preserve logical text alignment#17809ertugakmann wants to merge 1 commit into
ertugakmann wants to merge 1 commit into
Conversation
Contributor
Author
|
The PR's alignment regression tests pass (5/5). The CI failures appear unrelated to this change. The failing jobs are integration tests in unrelated areas:
The only production change in this PR is the Lexical HTML alignment conversion in No changes were made to the unrelated failing tests or CI configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Preserve Lexical's logical text alignment values when converting to HTML.
Before:
<p style="text-align: left;">Hello</p>After:
<p style="text-align: start;">Hello</p>Explicit
leftalignment is also now preserved instead of being omitted.Why?
startandendare logical CSS alignment values and should not be converted to physicalleftandrightvalues. Converting them can cause incorrect alignment for RTL content.How?
The Lexical → HTML converter now preserves the explicit alignment value instead of resolving
start/endto physical values.Added regression tests covering
start,end, explicitleft/right, and RTL direction.Tests:
pnpm vitest run packages/richtext-lexical/src/features/converters/lexicalToHtml/sync/alignment.spec.tsFixes #17784