refactor!: remove TypeWithID from public barrel export - #17808
Open
DanRibbens wants to merge 2 commits into
Open
refactor!: remove TypeWithID from public barrel export#17808DanRibbens wants to merge 2 commits into
DanRibbens wants to merge 2 commits into
Conversation
BREAKING CHANGE: TypeWithID is no longer exported from the `payload`
package barrel. In auth/user contexts, use the exported `User` type
instead. Consumers needing a generic { id } shape should inline it or
import from `payload/shared` where appropriate.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
DanRibbens
changed the title
Follow-up to removing TypeWithID from the public barrel. Re-expose it under payload/shared and update all internal packages that were importing TypeWithID from 'payload' to use 'payload/shared'. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
DanRibbens
requested review from
AlessioGr,
JarrodMFlesch,
denolfe and
jacobsfletch
as code owners
August 16, 2026 16:18
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeWithIDfrom thepayloadpackage barrel (bothsrc/index.tsand thesrc/types/index.tsre-export that flowed throughexport * from './types/index.js').TypeWithIDare unchanged; the type still lives atcollections/config/types.ts.Usertype (PayloadTypes['user'], already exported frompayload).Breaking change
import type { TypeWithID } from 'payload'no longer resolves. Replacement guidance:import type { User } from 'payload'{ id }shape → inline{ id: number | string }at the call siteTest plan
pnpm run lint— cleanpnpm run test:types— 212/212 pass (updatedtest/untyped/types.spec.tsto inline the shape)pnpm run build:core— clean🤖 Generated with Claude Code