chore: add ESLint quality gate - #198
Open
floze-the-genius wants to merge 1 commit into
Open
Conversation
floze-the-genius
force-pushed
the
chore/eslint-quality-gate
branch
from
August 9, 2026 18:09
d870f3a to
15e5123
Compare
Author
|
@kannupriyakalra This remains one current commit for your good-first issue #50. I refreshed the lockfile to patched brace-expansion 5.0.9 so the ESLint tooling adds no audit delta versus main (13 existing advisories on both). Fresh lint, typecheck, 120/120 tests, build, npm pack, audit comparison, and diff check pass on Node 22.23.1. The new Node 20/22 CI run is stopped at action_required before jobs start. Could you approve the workflow and review when convenient? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm run lintand run it in the existing Node 20/22 CI matrixThe config keeps existing
any, dynamicrequire, intentional empty catches, and current assignment patterns as explicit legacy baselines. This avoids broad unrelated source churn while still making the remaining recommended rules enforceable for new changes.Closes #50
Validation
npm run lintnpm run typechecknpm test— 120/120 passednpm run buildnpm pack --dry-runnpm audit— 13 existing advisories on both currentmainand this PR; no new advisory deltagit diff --checkAll commands passed on Node.js 22.23.1. The lockfile uses patched
brace-expansion5.0.9, avoiding the extra high advisory present in 5.0.7.Screenshots
Not applicable; this change only affects development tooling and CI.